Non-Apron relational domain dimchange tidyup#1754
Merged
Merged
Conversation
sim642
added
cleanup
michael-schwarz
approved these changes
May 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During the extension of the relational analyses with affine equalities and lin2vareq, we have had some refactorings that introduced some difficult implementation of the variable handling when scopes changed. In particular,
change_dwas having confusing, misnamed and undocumented parameters, that made it difficult for students and maintainers to get the semantics of the operations right, and also we did not handle the semantics of scope changes in synch with the Apron semantics .This PR serves for killing the undocumented boolean parameters and standardize dimchange semantics to the Apron standard.